On Wed, 8 Sep 2004 02:45:46 +0100 (IST) Dave Airlie <[EMAIL PROTECTED]> wrote:
> > sorry its in the kernel tarball... > > > > I'm game if you want to run it over the whole project. Let's merge > > dyn-minor first so I don't have to rewrite it. > > > > Are you ok with perm.patch going in? > > If it fixes up the savage put it in, the real work is starting to impinge > on my drm hacking at the moment, There's one more thing that came to my mind when I thought about how to make the Savage driver use initmap. (I havn't done it yet, though.) If the DDX tries to add a new map even though initmap was used and there is no such permanent map then addmap returns -EINVAL. Could it make a new map instead? (Just remove the return -EINVAL and let it fall through.) This would facilitate incremental driver development. For instance the Savage HwMC code uses a third framebuffer map. Since noone has made HwMC work yet, I wouldn't feel comfortable adding a permanent map for it yet. It may turn out to be useless in the end. The DDX should still have a chance to add the map, so this can be tried out first, before changing the kernel. Jon also mentioned the case where the offset isn't statically known but is somehow computed at runtime. I'm not sure if this is the case for HwMC, but allowing addmap to add new framebuffer maps in addition to permanent ones would make it possible. Maybe one would have to add some extra sanity checks to make sure that new maps don't overlap with permanent maps. Regards, Felix | Felix K�hling <[EMAIL PROTECTED]> http://fxk.de.vu | | PGP Fingerprint: 6A3C 9566 5B30 DDED 73C3 B152 151C 5CC1 D888 E595 | ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_idP47&alloc_id808&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
