> >
> > Using a standard no-op is a bit tricky as some fn return an int and some
> > void, but maybe I can use something like the attached patch?
>
> Looks good to me.
>

Actually after thinking about this some more I'm leaving the ifs in there,
there are few places in the code where it does more than just call the
function, at the chances of making those code sections a lot uglier I'm
happy with a few if statements that are at least meaningful, it reads
nicely if the driver has this function call the function...

Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person



-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to