In Keiths bunch of changes to make the drivers build in Mesa tree he changed the i810_dri .h from using drm_+clip_rect_t to XF86DRIClipRectRec, this break solo, if I change it back it'll probably break dri target...
which is correct?
Well, it depends...
The recent patch reverted the files in 'i810/server' to match the original versions of those files in XFree. This seems like a clean thing to do, but it does mean that the X types make it into the driver. We aren't immune from X types in the DRI client world because they are used in actual protocol communication with the X server, and this is one of the few cases where those protocol structs are much used by the driver.
Probably, the following statements are true:
- It's not desirable to directly include headers from the 2D DDX driver in the DRI client driver. In other words, anything in a server/ directory is probably suspect and needs review.
- The use of X-specific datatypes should be minimized as much as possible. In this case, using the DRM version is a good alternative. It would be good to push this choice deeper into the shared parts of the DRI client so that the existence of the two types with the same structure isn't even apparent to the drivers.
- Modifying files in server/ isn't desirable as they are effectively imports from XFree86, it would be better to create a new header in the driver directory or use one from elsewhere (often the DRM) which has the necessary definitions.
Keith
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
