On Sat, 2004-04-24 at 02:02, Adam Jackson wrote:
> On Wednesday 21 April 2004 19:49, Michel DÃnzer wrote:
> > On Wed, 2004-04-21 at 04:17, Adam Jackson wrote:
> > > I tend to agree. I don't think there's any list of requested modules
> > > maintained anywhere. tdfx does xf86LoaderCheckSymbol("DRIQueryVersion")
> > > to see if libdri.a loaded though, which is probably good enough; if the
> > > check fails the message can be degraded to an X_INFO. Sound reasonable?
> >
> > I think so. But, while you're at it... the drivers need an option to
> > enable/disable the DRI, otherwise there's no way to control which
> > card(s) to enable it on in a multi-card setup.
>
> Yes. That's a better idea than checking for symbol existance, actually.
> tdfx, i810, and mga already have a boolean Option "DRI" that does exactly
> this, so I copied that to the other drivers (defaulting it to "on"
> everywhere). This is used as the indicator of intent: the user is assumed to
> want DRI unless they say otherwise. If it's set false then none of the DRI
> init code will run, and the warning will be degraded to an info message. (If
> libdri doesn't get loaded then the initialization code will scream and yell
> anyway.)
IMHO it should work like this:
* If Option "DRI" isn't explicitly enabled or disabled (there's a
different boolean option handling function to check that), check
whether the dri module is loaded; if it is, assume that the user
wants the DRI to be enabled, otherwise assume he doesn't.
* If Option "DRI" is explicitly enabled, you know the user wants
it; load the dri module and initialize the DRI.
* If Option "DRI" is explicitly disabled, do nothing.
* If DRI initialisation fails, issue a warning if the user
(supposedly) wanted to enable it, an informational message
otherwise.
This way, existing configs work as before, but Option "DRI" allows
better control.
--
Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer
Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer
-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg=12297
--
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
