--- Eric Anholt <[EMAIL PROTECTED]> wrote: > Where is drmGetHardareInfo()? I forgot to copy it back into the DRI tree. New patch attached. > > If the DRM is copy_to_usering more data in the 1.1 interface verision, > the drmGetStats needs to be passing a larger struct in so that other > data won't be overwritten or EFAULT generated, right? Also, the 1.1 > interface has already gone downstream to at least one destination > (FreeBSD) so it would call for another minor bump, since there are side > effects.
Ok, I didn't think 1.1 had gone anywhere but CVS. > However, I'm not so sure about using the stats ioctl for this. Do we > need to be overloading things in the name of ioctl management? We've > used up 3/4 of the generic ioctl space from 0x0 to 0x40, and have > 0x80-0xff still. Also, couldn't we also use another DRM_IOCTL_BASE if > we somehow, some day ran out of ioctl space in the current one? I just > don't want to make our interfaces cruftier if we don't have to (or > unless it's for a good cause, such as encouraging removal of bad > interfaces in the future :) I'll go with whatever the decision is for overloading or a new number. I do think GetStats should be reworked to take a buffer size as it's first field. The way it is now we can't add any new stats. I'm starting to think that get FB start/length, MMIO start/length should be moved into a card specific IOCTL. Right now all cards have these four values but it may not be true in the future. PCI IDs and interrupt should stay generic since all cards have these. GetInterruptFromBusID can be elminated under version 1.1. > I don't think the kernel should be making the decision of telling > userland what the client driver name should be. What if we decide to > merge radeon and r200 DSOs at some point? Does your generic boot code > actually have nothing radeon-specific? Mesa solo works by having the OpenGL app link to libGL.so. libGL.so is completely driver agnostic. I've added code to libGL.so to open /dev/dri/card0 and extract the needed hardware info. With that data I can load the rest of the driver such as radeon_dri.so or r200_dri.so. It's radeon_dri.so and r200_dri.so that are closely tied to radeon DRM, not libGL.so. It would be better if the DRM driver said was xxxx_dri.so was needed for it. Previously a config file provided the DSO name. I'm trying to get this to work for the single card case without needing a config file. If there are multiple cards you may need a config file. ===== Jon Smirl [EMAIL PROTECTED] __________________________________ Do you Yahoo!? Exclusive Video Premiere - Britney Spears http://launch.yahoo.com/promos/britneyspears/
patch
Description: patch
