--- Michel D�nzer <[EMAIL PROTECTED]> wrote: > On Thu, 2003-09-11 at 17:32, Alex Deucher wrote: > > I did some basic work on factoring out the common code and > discussed it > > with Thomas Winischhofer (Sis maintainer and driving force behind > > mergedfb development). He is of the opinion that it is still too > early > > to create a generic API for mergedfb. There is still no consensus > on > > what the final look should be and whether or not we have a flexible > > enough model right now. Plus there are some new features in the > > pipeline that may require some reworking of the current common code > > (absolute offsets and panning domains). It's more of a pain to > have to > > constantly update the common code. > > And it's less painful to do the same changes in all the drivers, > possibly introducing inconsistencies? > >
I agree. I definitely would like to get over to the common code at some point, just not quite yet. right now there are just two drivers using it (sis and radeon) so it's not too hard to keep them in sync. FWIW, you can take a look at what I have done so far as far as factoring out the common code: http://www.botchco.com/alex/radeon/mergedfb/cvs/DRI/common/xf86mergedfb.c http://www.botchco.com/alex/radeon/mergedfb/cvs/DRI/common/xf86mergedfb.h if/when I get it working, I may attempt to maintain both the in-driver and common version so I can keep it up to date. What I don't want to happen is to have the common code merged, and have people start using it, only to find out later that it is flawed somehow. Alex __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
