Felix K�hling wrote:
> Hello,
> 
> Modifying the frame throttling code in r200_ioctl.c I removed
> R200_MAX_OUTSTANDING which is no longer needed there. It is, however,
> still used in r200Clear:
> 
>       if ( rmesa->sarea->last_clear - clear <= R200_MAX_OUTSTANDING+1 ) {
>        break;
>       }
> 
> The corresponding radeonClear uses a macro RADEON_MAX_CLEARS. There is a
> macro R200_MAX_CLEARS defined in r200_ioctl.c, too. But it is never used.
> Did I step on a bug here? Should I change this to
> 
>       if ( rmesa->sarea->last_clear - clear <= R200_MAX_CLEARS ) {
>        break;
>       }



If you want.  I think the number should be '1' in both cases.  I don't really 
see the need for a macro, even, as we've pretty much narrowed down the only 
acceptable value.


Keith



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to