Michael wrote: > > On Sun, Mar 10, 2002 at 07:28:21PM +0000, Keith Whitwell wrote: > > Are you sure? It loads *v into %ebx, then pulls it apart to %al, %cl > > > > 0x8b, 0x5c, 0x24, 0x08, /* mov 0x8(%esp,1), %ebx */ > > 0x8b, 0x1b, /* mov (%ebx), %ebx */ > > 0x88, 0xd8, /* mov %bl, %al */ > > 0x88, 0xf9, /* mov %bh, %cl */ > > > > It does this twice... > > Yeah, there was mixed 'what was wrong' and 'what is wrong' in my > explanation, this code is what I committed last night.
OK - that's why I didn't recognize the code above... > > Good point - these extra steps are skipped in the "cached codegen" case. But > > they really need to be done... > > Your CHOOSE_COLOR patch fixes what I was seeing in tuxracer. > > (q3 is looking much better, 102.8fps @ 640x480HQ with kludged page > flipping (adds about 7-8fps), 76.8 @ 800x600) Nice. How kludged is kludged? Keith _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
