Robin Redeker wrote:
> 
> On Wed, Feb 20, 2002 at 09:08:22AM -0700, Brian Paul wrote:
> > Robin Redeker wrote:
> [.snip-snap.]
> >
> > Could you link your app with "electric fence" (-lefence) and see if
> > it detects the out-of-bounds write?
> >
> > -Brian
> 
> Heh, it crashes earlier when linking with efence:
> --------------------------------
> #0  0x424e01fe in texsubimage2d_pack_bgr888_to_rgb565 (convert=0xbfffd5c4)
>     at ../../../../extras/Mesa/src/texutil_tmp.h:186
> #1  0x424e12c0 in convert_texsubimage2d_rgb565 (convert=0xbfffd5c4)
>     at texutil.c:514
> #2  0x424e6374 in _mesa_convert_texsubimage2d (mesaFormat=5, xoffset=0,
>     yoffset=0, width=1, height=1, imageWidth=1, format=6407, type=5121,
>     packing=0x48e60a78, srcImage=0x4925cffc, dstImage=0x49264ffc)
>     at texutil.c:1098
> #3  0x425567b4 in radeonDDTexImage2D (ctx=0x48e500d0, target=3553, level=6,
>     format=6407, type=5121, pixels=0x4925cffc, packing=0x48e60a78,
>     texObj=0x4923be40, texImage=0x49262fb8,
>     retainInternalCopy=0xbfffd6a7 "\001\003") at radeon_tex.c:439
> #4  0x424bf8ce in _mesa_TexImage2D (target=3553, level=6, internalFormat=3,
>     width=1, height=1, border=0, format=6407, type=5121, pixels=0x4925cffc)
>     at teximage.c:1521
> #5  0x400f43fd in gluBuild2DMipmapLevelsCore (target=3553, internalFormat=3,
>     width=64, height=64, widthPowerOf2=64, heightPowerOf2=64, format=6407,
>     type=5121, userLevel=0, baseLevel=0, maxLevel=6, data=0x49237000)
>     at mipmap.c:4487
> #6  0x400f4625 in gluBuild2DMipmaps (target=3553, internalFormat=3, width=64,
>     height=64, format=6407, type=5121, data=0x49237000) at mipmap.c:4562
> --------------------------------
> 
> But i wasn't able to get a message out of efence about memory clobbing or stuff.
> If i link it with it its onlt crashing earlier when using gluBuild2DMipmaps().


OK, it looks like the templatized code for texture image conversion is
the problem.  It's using the CONVERT_TEXEL_DWORD macro even when the
texture width is one, causing an out-of-bounds write.

I'll fix this up, Gareth :)

-Brian

_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to