On Wed 13 Feb 2002 15:41:08 +0000,
Keith Whitwell <[EMAIL PROTECTED]> wrote:
> Rik Faith wrote:
> >
> > Subject: drivers/char/drm/i810_dma.c
> > Date: Tue, 12 Feb 2002 15:07:02 -0500
> > From: Timothy Ball <[EMAIL PROTECTED]>
> > To: [EMAIL PROTECTED]
> >
> > do { ... } while(0); do not need the trailing semicolon and may lead to
> > strange side effects. the following patch fixes it.
> >
> > --timball
> >
> > --snip--snip--snip--
> > diff -ruN linux-2.5.4/drivers/char/drm/i810_dma.c
> > linux-2.5.4-fixed/drivers/char/drm/i810_dma.c
> > --- linux-2.5.4/drivers/char/drm/i810_dma.c Sun Feb 10 20:50:14 2002
> > +++ linux-2.5.4-fixed/drivers/char/drm/i810_dma.c Mon Feb 11 18:14:27
> > 2002
> > @@ -73,7 +73,7 @@
> > *(volatile unsigned int *)(virt + outring) = n; \
> > outring += 4; \
> > outring &= ringmask; \
> > -} while (0);
> > +} while (0)
> >
> > static inline void i810_print_status_page(drm_device_t *dev)
> > {
> >
>
> Looks good Rik,
>
> Do you want to commit this?
I can if that would be helpful (to the trunk?).
But if you're working on the driver, it would be wonderful if you can
just fold this in. We should also check for other instances of "while
(0);", since there seems to be a global clean up of these errors in the
kernel tree. (I grep'd my working tree and didn't see any others.)
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
