Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] i915/display: spelling mistake in TB_MIN_THESHOLD macro usage --
commit 468a8e227948c1192c42e05f62742d8315145e2f Author: Ankit Nautiyal <[email protected]> drm/i915/hdmi_frl_dfm: Add helpers to read/write FRL DFM registers This commit introduces helpers to read and write FRL Data Flow Metering registers. > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi_frl_dfm.c > b/drivers/gpu/drm/i915/display/intel_hdmi_frl_dfm.c > index fe1df69a10968..8062baed63db8 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi_frl_dfm.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi_frl_dfm.c [ ... ] > @@ -719,3 +724,40 @@ bool intel_hdmi_frl_dfm_dsc_requirement_met(struct > intel_hdmi_frl_dfm *frl_dfm) [ ... ] > +void intel_hdmi_frl_dfm_write(const struct intel_crtc_state *crtc_state) > +{ [ ... ] > + reg = TRANS_HDMI_FRL_DFMTHRSH(display, cpu_trans); > + val = TB_MIN_THESHOLD(crtc_state->frl.tb_threshold_min); > + intel_de_rmw(display, reg, TB_MIN_THESHOLD_MASK, val); [Severity: Low] This isn't a bug, but there appears to be a typo in the macro names TB_MIN_THESHOLD and TB_MIN_THESHOLD_MASK (missing the 'R' in THRESHOLD). Would it be worth updating the spelling to maintain consistency with adjacent macros and the struct field tb_threshold_min? > +} > + > +void intel_hdmi_frl_dfm_read(struct intel_crtc_state *crtc_state) > +{ [ ... ] > + val = intel_de_read(display, TRANS_HDMI_FRL_DFMTHRSH(display, > cpu_trans)); > + crtc_state->frl.tb_threshold_min = > + REG_FIELD_GET(TB_MIN_THESHOLD_MASK, val); [Severity: Low] This isn't a bug, but the same typo (THESHOLD instead of THRESHOLD) is also present here. > +} -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=32
