Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing required 'port' node in the adma_lcdif device tree definition. --
--- Patch [4]: [PATCH v2 4/7] arm64: dts: imx8-ss-dma: Add lcdif support for i.MX8QXP and i.MX8DXL --- commit 2f2508e8acf644f753c462595da01a137845e813 Author: Frank Li <[email protected]> arm64: dts: imx8-ss-dma: Add lcdif support for i.MX8QXP and i.MX8DXL This commit adds LCD interface (lcdif) device tree support for the i.MX8QXP and i.MX8DXL platforms. > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > index 4de78f870c05c..87082c3fa9338 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi [ ... ] > @@ -149,6 +149,24 @@ lpuart3: serial@5a090000 { > status = "disabled"; > }; > > + adma_lcdif: lcdif@5a180000 { > + compatible = "fsl,imx8qxp-lcdif", "fsl,imx6sx-lcdif"; [Severity: Low] Does this adma_lcdif node need a port sub-node to be defined here? The fsl,lcdif.yaml device tree binding schema explicitly requires a port node for all compatibles except fsl,imx28-lcdif. Omitting it will result in a validation warning during make dtbs_check against any board configuration that includes imx8-ss-dma.dtsi without adding the port node in the board-specific file. > + reg = <0x5a180000 0x10000>; > + clocks = <&lcd_clk_lpcg IMX_LPCG_CLK_0>, [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
