On Mon, Jun 29, 2026 at 01:23:38PM +0100, Lorenzo Stoakes wrote: > The only files which should be including vma.h are the implementation files > for the core VMA logic - vma.c, vma_init.c, and vma_exec.c. > > This is in order to allow for userland testing of core VMA logic. In this > cases, vma_internal.h and vma.h are included, providing both the > dependencies upon which the core VMA logic requires and its declarations. > > Userland testable VMA logic is achieved by having separate vma_internal.h > implementations for userland and kernel. > > Callers other than the core VMA implementation should include internal.h > instead. This header does not need to include vma_internal.h as it only > contains the vma.h declarations, for which the includes already present > suffice. > > Update code to reflect this, update comments to reflect the fact there are > 3 VMA implementation files and document things more clearly. > > While we're here, slightly improve the language of the comment describing > vma_exec.c. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes <[email protected]>
Reviewed-by: Gregory Price <[email protected]> > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ ... > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ ... > +/* > + * To allow for userland testing we place internal dependencies in > + * vma_internal.h and external VMA API declarations in vma.h. > + */ Do you actually need 3 copies of this comment or just one copy in vma_internal.h?
