Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Build failure due to referencing non-existent members in struct exynos_dp_device and unused static functions. --
commit aa4d752f4408535e5aa104d5d47b153a65ec83e2 Author: Jan Niedziolka <[email protected]> gpu/drm: Remove unused 'drm device *dev' parameter from drm_mode_create() This commit removes the unused struct drm_device *dev parameter from the drm_mode_create() prototype and definition. It also updates all calls to drm_mode_create() to reflect this change. > diff --git a/drivers/gpu/drm/exynos/exynos_dp.c > b/drivers/gpu/drm/exynos/exynos_dp.c > index b805403281504..78183809b4fb3 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp.c > +++ b/drivers/gpu/drm/exynos/exynos_dp.c > @@ -68,6 +68,53 @@ static int exynos_dp_poweroff(struct analogix_dp_plat_data > *plat_data) > return exynos_dp_crtc_clock_enable(plat_data, false); > } > > +static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector) > +{ > + struct exynos_dp_device *dp = to_dp(plat_data); > + struct drm_display_mode *mode; > + > + if (dp->plat_data.panel) > + return 0; > + > + mode = drm_mode_create(); > + if (!mode) { > + DRM_DEV_ERROR(dp->dev, > + "failed to create a new display mode.\n"); > + return 0; > + } > + > + drm_display_mode_from_videomode(&dp->vm, mode); [Severity: Low] Does this code compile successfully? Looking at the definition of struct exynos_dp_device, it doesn't appear to have a vm member. This might cause a build failure. > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + drm_mode_set_name(mode); > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, > + struct drm_bridge *bridge, > + struct drm_connector *connector) > +{ > + struct exynos_dp_device *dp = to_dp(plat_data); > + int ret; > + > + dp->connector = connector; [Severity: Low] Similarly here, is connector a valid member of struct exynos_dp_device? > + > + /* Pre-empt DP connector creation if there's a bridge */ > + if (dp->ptn_bridge) { [Severity: Low] And here, does struct exynos_dp_device have a ptn_bridge member? It looks like these functions might have been accidentally pasted from another driver during a rebase, as they don't seem to match the struct definition and don't appear to be referenced anywhere in this file. > + ret = drm_bridge_attach(&dp->encoder, dp->ptn_bridge, bridge, > + 0); > + if (ret) > + return ret; > + } > + > + return 0; > +} -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
