On Thu, Jun 25, 2026 at 07:10:55PM -0400, Lyude Paul wrote: > It turns out that the only reason our previous fixes looked like they > worked for this was because we would occasionally set the Gcoff state to 0 > in the normal S3 path, which fixed suspend/resume on desktops - but not on > machines using runtime suspend. > > The proper fix is to just never set this flag. Our current guess for the > reasoning behind this is that Gcoff likely coincides with GC6, and not > literally power off. > > Signed-off-by: Lyude Paul <[email protected]> > Fixes: 8302d0afeaec ("nouveau/gsp: fix suspend/resume regression on r570 > firmware") > Cc: <[email protected]> > Cc: Lyude Paul <[email protected]> > Cc: Dave Airlie <[email protected]> > Cc: Kees Cook <[email protected]> > Cc: Danilo Krummrich <[email protected]> > Cc: Timur Tabi <[email protected]> > Cc: Ben Skeggs <[email protected]> > Cc: Andy Shevchenko <[email protected]> > Cc: Mel Henning <[email protected]> > Cc: <[email protected]> # v6.19+ > --- > drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Same comment here. -- With Best Regards, Andy Shevchenko
