Hi sashiko, Thanks for the review.
> -----Original Message----- > From: dri-devel <[email protected]> On Behalf Of > [email protected] > Sent: 19 June 2026 11:20 > To: biju.das.au <[email protected]> > Cc: wsa+renesas <[email protected]>; > [email protected] > Subject: Re: [PATCH v4 2/2] drm: renesas: rz-du: Add support for RZ/G3L LVDS > encoder > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) > to consider: > - [High] Sleeping functions called in atomic context during bridge enable Can you please let me know which is atomic context here? Probe: No sleeping context [ 19.611090] rzg3l_lvds_atomic_enable+0x18/0x16c [rzg3l_lvds] (P) [ 19.611106] drm_atomic_bridge_chain_enable+0x60/0xb0 [drm] [ 19.611287] drm_atomic_helper_commit_encoder_bridge_enable+0xdc/0x140 [drm_kms_helper] [ 19.611386] drm_atomic_helper_commit_tail_rpm+0x80/0xe0 [drm_kms_helper] [ 19.611456] commit_tail+0xa4/0x1a4 [drm_kms_helper] [ 19.611524] drm_atomic_helper_commit+0x17c/0x1b0 [drm_kms_helper] [ 19.611593] drm_atomic_commit+0x8c/0xcc [drm] [ 19.611766] drm_client_modeset_commit_atomic+0x224/0x294 [drm] [ 19.611937] drm_client_modeset_commit_locked+0x5c/0x188 [drm] [ 19.612108] drm_client_modeset_commit+0x2c/0x58 [drm] [ 19.612280] __drm_fb_helper_restore_fbdev_mode_unlocked.part.0+0x90/0xa0 [drm_kms_helper] [ 19.612348] drm_fb_helper_set_par+0x68/0x84 [drm_kms_helper] [ 19.612417] fbcon_init+0x4fc/0x520 [ 19.612435] visual_init+0xb4/0x104 [ 19.612449] do_bind_con_driver.isra.0+0x1c4/0x374 [ 19.612462] do_take_over_console+0x1a0/0x200 [ 19.612474] do_fbcon_takeover+0x6c/0xe0 [ 19.612485] fbcon_fb_registered+0x1dc/0x1e0 [ 19.612497] do_register_framebuffer+0x198/0x254 [ 19.612507] register_framebuffer+0x2c/0x50 [ 19.612516] __drm_fb_helper_initial_config_and_unlock+0x330/0x5cc [drm_kms_helper] [ 19.612583] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper] [ 19.612651] drm_fbdev_client_hotplug+0x7c/0xdc [drm_client_lib] [ 19.612669] drm_client_register+0x58/0x9c [drm] [ 19.612839] drm_fbdev_client_setup+0xa4/0xce0 [drm_client_lib] [ 19.612853] drm_client_setup+0xb0/0xe0 [drm_client_lib] [ 19.612863] rzg2l_du_probe+0x134/0x174 [rzg2l_du_drm] Suspend to RAM: no sleeping context [ 79.238581] rzg3l_lvds_atomic_enable+0x18/0x16c [rzg3l_lvds] (P) [ 79.238595] drm_atomic_bridge_chain_enable+0x60/0xb0 [drm] [ 79.238764] drm_atomic_helper_commit_encoder_bridge_enable+0xdc/0x140 [drm_kms_helper] [ 79.238876] drm_atomic_helper_commit_tail_rpm+0x80/0xe0 [drm_kms_helper] [ 79.238947] commit_tail+0xa4/0x1a4 [drm_kms_helper] [ 79.239014] drm_atomic_helper_commit+0x17c/0x1b0 [drm_kms_helper] [ 79.239080] drm_atomic_commit+0x8c/0xcc [drm] [ 79.239251] drm_atomic_helper_commit_duplicated_state+0x134/0x148 [drm_kms_helper] [ 79.239319] drm_atomic_helper_resume+0xac/0x19c [drm_kms_helper] [ 79.239389] drm_mode_config_helper_resume+0x24/0xc0 [drm_kms_helper] [ 79.239459] rzg2l_du_pm_resume+0x18/0x24 [rzg2l_du_drm] [ 79.239479] device_resume+0xc8/0x1c4 [ 79.239496] dpm_resume+0x198/0x1b8 [ 79.239505] dpm_resume_end+0x18/0x34 [ 79.239514] suspend_devices_and_enter+0x224/0x590 [ 79.239530] pm_suspend+0x194/0x1c0 [ 79.239539] state_store+0x80/0xf4 [ 79.239549] kobj_attr_store+0x18/0x34 [ 79.239563] sysfs_kf_write+0x7c/0xa0 [ 79.239575] kernfs_fop_write_iter+0x130/0x200 Hotplug: ] rzg3l_lvds_atomic_enable+0x18/0x16c [rzg3l_lvds] (P) [ 235.264272] drm_atomic_bridge_chain_enable+0x60/0xb0 [drm] [ 235.272544] drm_atomic_helper_commit_encoder_bridge_enable+0xdc/0x140 [drm_kms_helper] [ 235.281610] drm_atomic_helper_commit_tail_rpm+0x80/0xe0 [drm_kms_helper] [ 235.289443] commit_tail+0xa4/0x1a4 [drm_kms_helper] [ 235.295459] commit_work+0x14/0x20 [drm_kms_helper] [ 235.301397] process_one_work+0x154/0x290 [ 235.305625] worker_thread+0x184/0x2f4 [ 235.309571] kthread+0x118/0x130 [ 235.312982] ret_from_fork+0x10/0x20 > - [High] Early returns in `atomic_enable` cause unbalanced PM counter and > unpowered hardware access in > `atomic_disable` > -- So far during testing no issues found, WARN_ON is added to find any such issues in future. Cheers, Biju
