Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incorrect vertical import sorting in the `devres.rs` doc-comment. --
commit 44ae5967f8fb0af22e020970c5e4e5cc392db95a Author: Gary Guo <[email protected]> Io trait is now very easy to implement. Thus, implement it on Bar and IoMem directly and remove the MmioOwned struct. This commit simplifies the Io trait usage by implementing it directly on Bar and IoMem. It removes the intermediate MmioOwned struct and updates the relevant device resource documentation and examples to reflect these changes. > diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs > index aed0c994fd30..3545ffc5345d 100644 > --- a/rust/kernel/devres.rs > +++ b/rust/kernel/devres.rs > @@ -68,8 +68,9 @@ struct Inner<T> { > /// devres::Devres, > /// io::{ > /// Io, > -/// MmioOwned, > +/// Mmio, > /// MmioRaw, > +/// MmioBackend, [Severity: Low] This isn't a bug, but the imports in this documentation block appear to be out of alphabetical order. According to the Rust kernel coding guidelines for vertical imports, shouldn't MmioBackend be placed before MmioRaw? > /// PhysAddr, > /// Region, // > /// }, -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=10
