Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing type and value constraints for `rotation` property in device tree binding. --
commit 4e4bbc4176c7e781dd970cf6e2d43e667642bddd Author: Amit Barzilai <[email protected]> dt-bindings: display: Add Solomon SSD1351 OLED controller This commit adds a new device tree binding for the Solomon SSD1351 OLED display controller. It defines the standard properties and builds upon the shared solomon,ssd-common.yaml schema. > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml > new file mode 100644 > index 0000000000000..a7d77132faa63 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1351.yaml [ ... ] > +properties: > + compatible: > + enum: > + - solomon,ssd1351 > + > + solomon,width: > + default: 128 > + > + solomon,height: > + default: 128 > + > + rotation: true [Severity: Low] Does this permit the rotation property without enforcing type validation? Without including a reference to panel/panel-common.yaml# (or a direct type definition), dt_binding_check will not enforce that rotation is a uint32 or restricted to valid degrees (0, 90, 180, 270). This could allow incorrectly typed device tree entries to pass schema validation but fail at runtime when the driver attempts to call device_property_read_u32. > + > +required: > + - compatible > + - reg [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
