Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing `EXPORT_SYMBOL_GPL()` for EDID test arrays causes module build failure when `CONFIG_DRM_KUNIT_TEST=m`. --
commit 981eca4f730b2b2f411ac7f7d770b14bbb79bd75 Author: Nicolas Frattaroli <[email protected]> drm/tests: Move test EDID data to separate .c file This commit moves test EDID arrays from a header file to a separate .c file to prevent duplicate definitions. The array declarations in the header are updated to use extern and explicitly state their sizes. Link: https://lore.kernel.org/r/[email protected]/ > diff --git a/drivers/gpu/drm/tests/Makefile b/drivers/gpu/drm/tests/Makefile > index 3b83e6616fb25..e7193b49cf91f 100644 > --- a/drivers/gpu/drm/tests/Makefile > +++ b/drivers/gpu/drm/tests/Makefile [ ... ] > @@ -24,6 +24,7 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ > drm_probe_helper_test.o \ > drm_rect_test.o \ > drm_sysfb_modeset_test.o \ > - drm_fixp_test.o > + drm_fixp_test.o \ > + drm_kunit_edid.o > > CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN) > diff --git a/drivers/gpu/drm/tests/drm_kunit_edid.c > b/drivers/gpu/drm/tests/drm_kunit_edid.c > new file mode 100644 > index 0000000000000..fae92e5bef30a > --- /dev/null > +++ b/drivers/gpu/drm/tests/drm_kunit_edid.c > @@ -0,0 +1,217 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include "drm_kunit_edid.h" > + > +const unsigned char test_edid_dvi_1080p[] = { [Severity: Low] Does this code need to export the array variables using EXPORT_SYMBOL_GPL()? When CONFIG_DRM_KUNIT_TEST=m, Kbuild compiles each .o file added to obj-$(CONFIG_DRM_KUNIT_TEST) as a separate loadable kernel module. Without exporting these newly moved test arrays, will compiling other test modules that reference them fail with undefined symbol errors during modpost? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/20260610-test-edid-array-definition-fix-v1-1-4467ba487...@collabora.com?part=1
