Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The prototype for `drm_atomic_set_colorop_for_plane` was not removed from the header file when the function was renamed and made static. --
commit db8489fc6303b4a6973676321220c79b3ad4273f Author: John Harrison <[email protected]> drm/colorop: Reduce scope of colorop helpers This commit reduces the scope of drm_colorop_find and drm_atomic_set_colorop_for_plane by making them static local helpers within the drm_atomic_uapi.c file. > diff --git a/drivers/gpu/drm/drm_atomic_uapi.c > b/drivers/gpu/drm/drm_atomic_uapi.c > index 6441b55cc2740..530576850239f 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c [ ... ] > @@ -259,16 +259,16 @@ drm_atomic_set_fb_for_plane(struct drm_plane_state > *plane_state, > EXPORT_SYMBOL(drm_atomic_set_fb_for_plane); > > /** > - * drm_atomic_set_colorop_for_plane - set colorop for plane > + * set_colorop_for_plane - set colorop for plane > * @plane_state: atomic state object for the plane > * @colorop: colorop to use for the plane > * > * Helper function to select the color pipeline on a plane by setting > * it to the first drm_colorop element of the pipeline. > */ > -void > -drm_atomic_set_colorop_for_plane(struct drm_plane_state *plane_state, > - struct drm_colorop *colorop) > +static void > +set_colorop_for_plane(struct drm_plane_state *plane_state, > + struct drm_colorop *colorop) [Severity: Low] Since the exported function drm_atomic_set_colorop_for_plane is being renamed and made static here, should its corresponding declaration in include/drm/drm_atomic_uapi.h also be removed? The prototype remains in that header file without an implementation, leaving a dangling declaration. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
