The cdns-dsi bridge open-codes the bridge state initialization with a memset and a manual assignment of the bridge pointer.
The memset is redundant since the state is already kzalloc-ed, and __drm_atomic_helper_bridge_state_init() exists for exactly this purpose. Switch to it. Signed-off-by: Maxime Ripard <[email protected]> --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index cf90d4468b5c..f4cf765f0be8 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -1015,12 +1015,11 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge) dsi_state = kzalloc_obj(*dsi_state); if (!dsi_state) return NULL; - memset(dsi_state, 0, sizeof(*dsi_state)); - dsi_state->base.bridge = bridge; + __drm_atomic_helper_bridge_state_init(&dsi_state->base, bridge); return &dsi_state->base; } static const struct drm_bridge_funcs cdns_dsi_bridge_funcs = { -- 2.54.0
