On Fri, 15 May 2026, Harrison Vanderbyl wrote: > Add a SAM client device node group and registry entry for the > Microsoft Surface Pro, 12-inch with Snapdragon. > > This set enables the use of the following devices. > 1: cover keyboard > 2: cover touchpad > 3: pen stash events. > > The battery info and charger info devices have been > purposefully omitted as they are also reported by > other drivers and cause conflicts. > > Signed-off-by: Harrison Vanderbyl <[email protected]> > --- > .../surface/surface_aggregator_registry.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/platform/surface/surface_aggregator_registry.c > b/drivers/platform/surface/surface_aggregator_registry.c > index 0599d5adf02e..884049961415 100644 > --- a/drivers/platform/surface/surface_aggregator_registry.c > +++ b/drivers/platform/surface/surface_aggregator_registry.c > @@ -422,6 +422,19 @@ static const struct software_node > *ssam_node_group_sp11[] = { > NULL, > }; > > +/* Devices for Surface Pro 12" first edition (ARM/QCOM) */ > +static const struct software_node *ssam_node_group_sp12in[] = { > + &ssam_node_root, > + &ssam_node_hub_kip, > + &ssam_node_tmp_sensors, > + &ssam_node_hid_kip_keyboard, > + &ssam_node_hid_sam_penstash,
Hi, Could you please confirm this penstash is correct (sam vs kip)? Sashiko suggested it might be wrong but take it's report with a grain of salt, it's AI after all and sometimes seems to extrapolate about HW to a sibling HW without any real knowledge: https://sashiko.dev/#/patchset/cover.1778822464.git.harrison.vanderbyl%40gmail.com -- i. > + &ssam_node_hid_kip_touchpad, > + &ssam_node_hid_kip_fwupd, > + &ssam_node_pos_tablet_switch, > + NULL, > +}; > + > /* -- SSAM platform/meta-hub driver. > ---------------------------------------- */ > > static const struct acpi_device_id ssam_platform_hub_acpi_match[] = { > @@ -500,6 +513,8 @@ static const struct of_device_id > ssam_platform_hub_of_match[] __maybe_unused = { > { .compatible = "microsoft,arcata", (void *)ssam_node_group_sp9_5g }, > /* Surface Pro 11 (ARM/QCOM) */ > { .compatible = "microsoft,denali", (void *)ssam_node_group_sp11 }, > + /* Surface Pro 12in First Edition (ARM/QCOM) */ > + { .compatible = "microsoft,surface-pro-12in", (void > *)ssam_node_group_sp12in }, > /* Surface Laptop 7 */ > { .compatible = "microsoft,romulus13", (void *)ssam_node_group_sl7 }, > { .compatible = "microsoft,romulus15", (void *)ssam_node_group_sl7 },
