On 5/24/26 18:01, Myeonghun Pak wrote:
meson_drv_bind_master() starts the KMS polling helper before registering the DRM device. If drm_dev_register() fails, probe unwinds the IRQ and DRM device without stopping the polling helper.Call drm_kms_helper_poll_fini() on that failure path before freeing the IRQ. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Cc: [email protected] Co-developed-by: Ijae Kim <[email protected]> Signed-off-by: Ijae Kim <[email protected]> Signed-off-by: Myeonghun Pak <[email protected]> --- drivers/gpu/drm/meson/meson_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 49ff9f1f16..e49de5df73 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -352,12 +352,14 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)ret = drm_dev_register(drm, 0);if (ret) - goto uninstall_irq; + goto uninstall_poll;drm_client_setup(drm, NULL); return 0; +uninstall_poll:+ drm_kms_helper_poll_fini(drm); uninstall_irq: free_irq(priv->vsync_irq, drm); exit_afbcd:
Reviewed-by: Neil Armstrong <[email protected]> Thanks, Neil
