'struct configfs_item_operations' and 'configfs_group_operations' are not modified in this driver.
Constifying these structures moves some data to a read-only section, so increases overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig, as an example: Before: ====== text data bss dec hex filename 34095 15704 128 49927 c307 drivers/gpu/drm/xe/xe_configfs.o After: ===== text data bss dec hex filename 34447 15352 128 49927 c307 drivers/gpu/drm/xe/xe_configfs.o Signed-off-by: Christophe JAILLET <[email protected]> --- Compile tested only. --- drivers/gpu/drm/xe/xe_configfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c index 32102600a148..5c2072f18a57 100644 --- a/drivers/gpu/drm/xe/xe_configfs.c +++ b/drivers/gpu/drm/xe/xe_configfs.c @@ -838,7 +838,7 @@ static void xe_config_device_release(struct config_item *item) kfree(dev); } -static struct configfs_item_operations xe_config_device_ops = { +static const struct configfs_item_operations xe_config_device_ops = { .release = xe_config_device_release, }; @@ -855,7 +855,7 @@ static bool xe_config_device_is_visible(struct config_item *item, return true; } -static struct configfs_group_operations xe_config_device_group_ops = { +static const struct configfs_group_operations xe_config_device_group_ops = { .is_visible = xe_config_device_is_visible, }; @@ -950,7 +950,7 @@ static bool xe_config_sriov_is_visible(struct config_item *item, return true; } -static struct configfs_group_operations xe_config_sriov_group_ops = { +static const struct configfs_group_operations xe_config_sriov_group_ops = { .is_visible = xe_config_sriov_is_visible, }; @@ -1054,7 +1054,7 @@ static struct config_group *xe_config_make_device_group(struct config_group *gro return &dev->group; } -static struct configfs_group_operations xe_config_group_ops = { +static const struct configfs_group_operations xe_config_group_ops = { .make_group = xe_config_make_device_group, }; -- 2.54.0
