Hi Maciej, Karol,

I noticed the TODO at ivpu_ipc.c:100 regarding setting data_size to the
actual JSM message size rather than sizeof(full union). I'd like to work
on this.

My proposed approach: add a u32 msg_size parameter to ivpu_ipc_send() and
ivpu_ipc_tx_prepare(), passing offsetof(struct vpu_jsm_msg, payload) +
sizeof() of the specific payload from each call site in ivpu_jsm_msg.c.

Before proceeding -- is there a firmware compatibility constraint that
intentionally kept this at sizeof(struct vpu_jsm_msg)? And is this the
right tree (drm/misc/kernel) for this change?

Background: I'm a Linux kernel contributor (IIO/ASoC/SCSI patches
upstream) interested in the accel/NPU subsystem.

Regards,
Md Shofiqul Islam

Reply via email to