On 3/27/26 00:35, Miguel Ojeda wrote:
On Thu, Mar 26, 2026 at 7:55 AM Alvin Sun <[email protected]> wrote:
Fixes clippy warning:
warning: all variants have the same postfix: `Init`
--> rust/kernel/sync/set_once.rs:68:1
Is this fixing an issue earlier in the series?
If so, then I would suggest just fixing the patch that introduced the
issue directly (since you are not the author, you can use square
brackets between the Signed-off-bys to indicate what you changed. I
agree with Gary that is may be simpler to just allow the warning.
Agreed. This clippy warning already exists in Gary's original patch.
I'll fix it
there by allowing the warning directly, and add a square-bracket note
between
the Signed-off-bys describing the change.
Thanks,
Alvin
If not, then please add a Fixes: tag pointing to the commit being fixed.
(By the way, if you do keep this patch, then please copy-paste more of
the warning, i.e. it doesn't say what lint is being triggered. In
addition, the imperative mood is what is expected in commit messages
for the kernel.)
Thanks!
Cheers,
Miguel
