Hello, On Fri Mar 20, 2026 at 11:46 AM CET, Luca Ceresoli wrote: > Putting the remote device_node reference requires a of_node_put(ep) in both > error return points. Use a cleanup action to simplify the code. > > Signed-off-by: Luca Ceresoli <[email protected]> > --- > drivers/gpu/drm/mxsfb/lcdif_drv.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c > b/drivers/gpu/drm/mxsfb/lcdif_drv.c > index 47da1d9336b9..756ca96373c8 100644 > --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c > +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c > @@ -53,16 +53,13 @@ static int lcdif_attach_bridge(struct lcdif_drm_private > *lcdif) > int ret; > > for_each_endpoint_of_node(dev->of_node, ep) { > - struct device_node *remote; > + struct device_node *remote __free(drm_bridge_put) = ^^^^^^^^^^^^^^
I just realized there's a mistake here, this should be __free(device_node). However this does not prevent testing the series in its entirety because patch 2 fixes this mistake. Will be fixed in v2. Sorry about the noise, did too many rebases today! Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
