On 05/02/2026 21:31, Maíra Canal wrote:
Introduce `struct vc4_job` as the new base structure for GPU jobs, with
`vc4_bin_job` and `vc4_render_job` as specialized variants for BIN and
RENDER jobs, respectively. These structures embed `struct drm_sched_job`
and will be used with the DRM GPU scheduler.
The `vc4_exec_info` struct now holds pointers to these job structs,
allowing the existing validation code to populate job fields during
command list processing. Each submission will have a `vc4_exec_info`,
and each execution info will hold a BIN and RENDER job.
This design is largely inspired by the v3d driver's job structures.
Not sure this patch is worth to have standalone. I am tempted to suggest
squashing it with 5/11 and in there only have the fields which are
actually used in 5/11. But lets hold off that for now until I
familiarise myself more with the series.
Regards,
Tvrtko
Signed-off-by: Maíra Canal <[email protected]>
---
drivers/gpu/drm/vc4/vc4_drv.h | 79 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index
0f2fb035fef177dd446ff8322da2413c861ecfd3..0f6b7cda1193f0e5ee6b7a504ff447460dedab20
100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -152,6 +152,10 @@ struct vc4_dev {
*/
uint64_t emit_seqno;
+ struct vc4_bin_job *bin_job;
+
+ struct vc4_render_job *render_job;
+
/* Sequence number for the last completed job on the GPU.
* Starts at 0 (no jobs completed).
*/
@@ -668,9 +672,84 @@ struct vc4_crtc_state {
#define VC4_REG32(reg) { .name = #reg, .offset = reg }
+struct vc4_job {
+ struct drm_sched_job base;
+
+ struct kref refcount;
+
+ struct vc4_dev *vc4;
+
+ /* v3d fence to be signaled by IRQ handler when the job is complete. */
+ struct dma_fence *irq_fence;
+
+ /* scheduler fence for when the job is considered complete and
+ * the BO reservations can be released.
+ */
+ struct dma_fence *done_fence;
+
+ /* Last current and return addresses the hardware was processing when
+ * the job timedout.
+ */
+ u32 timedout_ctca, timedout_ctra;
+
+ /* Pointer to a performance monitor object if the user requested it,
+ * NULL otherwise.
+ */
+ struct vc4_perfmon *perfmon;
+
+ /* Callback for the freeing of the job on refcount going to 0. */
+ void (*free)(struct kref *ref);
+};
+
+struct vc4_bin_job {
+ struct vc4_job base;
+
+ uint32_t ct0ca, ct0ea;
+
+ /* Corresponding render job, for attaching our overflow memory. */
+ struct vc4_render_job *render;
+
+ /* Whether the exec has taken a reference to the binner BO, which should
+ * happen with a VC4_PACKET_TILE_BINNING_MODE_CONFIG packet.
+ */
+ bool bin_bo_used;
+};
+
+struct vc4_render_job {
+ struct vc4_job base;
+
+ uint32_t ct1ca, ct1ea;
+
+ /* This is the array of BOs that were looked up at the start of
submission.
+ * Command validation will use indices into this array.
+ */
+ struct drm_gem_object **bo;
+ u32 bo_count;
+
+ /* List of other BOs used in the job that need to be released
+ * once the job is complete.
+ */
+ struct list_head unref_list;
+
+ /* List of BOs that are being written by the RCL. Other than
+ * the binner temporary storage, this is all the BOs written
+ * by the job.
+ */
+ struct drm_gem_dma_object *rcl_write_bo[4];
+ uint32_t rcl_write_bo_count;
+
+ /* Bitmask of which binner slots are freed when this job completes.
+ * Must remain allocated until the render job completes.
+ */
+ uint32_t bin_slots;
+};
+
struct vc4_exec_info {
struct vc4_dev *dev;
+ struct vc4_bin_job *bin;
+ struct vc4_render_job *render;
+
/* Sequence number for this bin/render job. */
uint64_t seqno;
