Re: [PATCH v8 8/8] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

[Andreas Kemnade]

On Mon, 23 Feb 2026 08:49:40 -0500
Mithil Bavishi <bavishimit...@gmail.com> wrote:

> Create a device tree for the 10 inch variants (P5100, P5110, P5113)
> 
> Signed-off-by: Mithil Bavishi <bavishimit...@gmail.com>
> ---
>  arch/arm/boot/dts/ti/omap/Makefile            |   1 +
>  .../dts/ti/omap/omap4-samsung-espresso10.dts  | 104 ++++++++++++++++++
>  2 files changed, 105 insertions(+)
>  create mode 100644 arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts
> 
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile 
> b/arch/arm/boot/dts/ti/omap/Makefile
> index d24f13efd..140ac39b3 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_OMAP4) += \
>       omap4-var-dvk-om44.dtb \
>       omap4-var-stk-om44.dtb \
>       omap4-samsung-espresso7.dtb \
> +     omap4-samsung-espresso10.dtb \
>       omap4-xyboard-mz609.dtb \
>       omap4-xyboard-mz617.dtb
>  dtb-$(CONFIG_SOC_AM33XX) += \
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts 
> b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts
> new file mode 100644
> index 000000000..5c00d67ac
> --- /dev/null
> +++ b/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dts
> @@ -0,0 +1,104 @@
[...]

> +&i2c3 {
> +     touchscreen@20 {
> +             compatible = "syna,rmi4-i2c";
> +             reg = <0x20>;
> +             #address-cells = <1>;
> +             #size-cells = <0>;
> +
> +             interrupt-parent = <&gpio2>;
> +             interrupts = <14 IRQ_TYPE_EDGE_FALLING>;
> +
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&touch_pins>;
> +
> +             //avdd-supply = <&reg_touch_ldo_en>;
> +             vdd-supply = <&ldo6>;
> +
> +             syna,reset-delay-ms = <200>;
> +             syna,startup-delay-ms = <200>;
> +
> +             touchscreen-size-x = <1280>;
> +             touchscreen-size-y = <800>;
> +
duplicated,

> +             rmi4-f01@1 {
> +                     reg = <0x01>;
> +                     syna,nosleep-mode = <1>;
> +             };
> +
> +             rmi4-f11@11 {
> +                     reg = <0x11>;
> +                     touchscreen-size-x = <1280>;
> +                     touchscreen-size-y = <800>;
it is needed and accepted only here.


Regards,
Andreas