On 2/27/26 13:49, Tvrtko Ursulin wrote: > Fix a nasty copy and paste bug, where the incorrect boolean return type of > the ttm_pool_beneficial_order() helper had a consequence of avoiding > direct reclaim too eagerly for drivers which use this feature (currently > amdgpu). > > Signed-off-by: Tvrtko Ursulin <[email protected]> > Fixes: 7e9c548d3709 ("drm/ttm: Allow drivers to specify maximum beneficial > TTM pool size") > Cc: Christian König <[email protected]> > Cc: Thadeu Lima de Souza Cascardo <[email protected]> > Cc: [email protected] > Cc: <[email protected]> # v6.19+
Good catch, Reviewed-by: Christian König <[email protected]> > --- > drivers/gpu/drm/ttm/ttm_pool_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_pool_internal.h > b/drivers/gpu/drm/ttm/ttm_pool_internal.h > index 82c4b7e56a99..24c179fd69d1 100644 > --- a/drivers/gpu/drm/ttm/ttm_pool_internal.h > +++ b/drivers/gpu/drm/ttm/ttm_pool_internal.h > @@ -17,7 +17,7 @@ static inline bool ttm_pool_uses_dma32(struct ttm_pool > *pool) > return pool->alloc_flags & TTM_ALLOCATION_POOL_USE_DMA32; > } > > -static inline bool ttm_pool_beneficial_order(struct ttm_pool *pool) > +static inline unsigned int ttm_pool_beneficial_order(struct ttm_pool *pool) > { > return pool->alloc_flags & 0xff; > }
