On Thu Feb 19, 2026 at 4:30 PM JST, Eliot Courtney wrote: > Add a helper function which computes the size of a command. > > Signed-off-by: Eliot Courtney <[email protected]> > --- > drivers/gpu/nova-core/gsp/cmdq.rs | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs > b/drivers/gpu/nova-core/gsp/cmdq.rs > index 1547687834f8..f832252ae45c 100644 > --- a/drivers/gpu/nova-core/gsp/cmdq.rs > +++ b/drivers/gpu/nova-core/gsp/cmdq.rs > @@ -437,6 +437,15 @@ struct GspMessage<'a> { > contents: (&'a [u8], &'a [u8]), > } > > +/// Computes the total size of the command (not including the > [`GspMsgElement`] header), including > +/// its variable-length payload.
This comment reads a bit funny with the "not including but including". How about "... size of the command (including its variable-length payload) without the [`GspMsgElement`] header" ?
