Hi
Am 22.02.26 um 07:45 schrieb Hardik Phalet:
Hi Ruben,
I am looking to work on a small starter task in DRM and was considering
converting logging in drivers/gpu/drm/gud from dev_info/dev_warn/dev_err
to the drm_*() helpers where a struct drm_device is already (or readily)
available.
Since GUD is a USB-backed DRM driver and can have multiple active
instances, using drm_*() would make log messages instance-aware and
consistent with DRM drivers.
Before preparing a patch series, I wanted to check whether this kind of
conversion is welcome for GUD, and whether there are any parts of the driver
you would prefer to keep using dev_*() instead of drm_*().
If this is fine, I plan to keep the changes mechanical and scoped only to
call sites where drm_device is already in scope, preserving logging
semantics.
I'm not Ruben, but generally speaking that conversion of the logging is
ok. But there's not much in gud to convert and the early calls in
gud_probe() should rather not be converted.
If you're looking for an easy task, maybe try open-coding
drm_simple_encoder_init(). There's an upcoming TODO item at [1].
Best regards
Thomas
[1]
https://lore.kernel.org/dri-devel/[email protected]/T/#Z2e.:..:20260224153656.261351-17-tzimmermann::40suse.de:1Documentation:gpu:todo.rst
Thanks,
Hardik
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
