On Tue, Feb 24, 2026 at 02:39:17PM +0100, Maarten Lankhorst wrote: > Hey, > > Den 2026-02-23 kl. 23:29, skrev Matthew Brost: > > From: Bart Van Assche <[email protected]> > > > > Although freeing a spinlock without unlocking it is fine, this confuses > > static analyzers. Hence this patch. > > > > Fixes: 77f14f2f2d73 ("drm/pagemap: Add a drm_pagemap cache and shrinker") > > Cc: Maarten Lankhorst <[email protected]> > > Cc: Maxime Ripard <[email protected]> > > Cc: Thomas Zimmermann <[email protected]> > > Cc: Thomas Hellström <[email protected]> > > Cc: Matthew Brost <[email protected]> > > Signed-off-by: Bart Van Assche <[email protected]> > > Reviewed-by: Matthew Brost <[email protected]> > > --- > > drivers/gpu/drm/drm_pagemap_util.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_pagemap_util.c > > b/drivers/gpu/drm/drm_pagemap_util.c > > index 14ddb948a32e..50cb5f9cdac5 100644 > > --- a/drivers/gpu/drm/drm_pagemap_util.c > > +++ b/drivers/gpu/drm/drm_pagemap_util.c > > @@ -74,6 +74,8 @@ static void drm_pagemap_cache_fini(void *arg) > > cache->dpagemap = NULL; > > spin_unlock(&cache->lock); > > drm_pagemap_destroy(dpagemap, false); > > + } else { > > + spin_unlock(&cache->lock); > > } > > > > out: > > What about this idea? > > https://lore.kernel.org/all/[email protected]/
Yes, that's better - I reposted this yesterday while a bit overloaded to make sure this didn't get lost. Let's use the a version posted in the above link. Matt
