On Tue, Feb 10, 2026 at 09:38:12PM +0300, Onur Özkan wrote: > GpuInfo::log() was decoding GPU_ID like this: > > major = (self.gpu_id >> 16) & 0xff; > minor = (self.gpu_id >> 8) & 0xff; > status = self.gpu_id & 0xff; > > That does not match the Mali GPU_ID layout and mixes unrelated > fields. Due to that, model detection becomes `mali-unknown` on > rk3588s which is wrong. > > We can already get all the version information with a single > GpuId::from call (less code and cleaner), so this patch uses it. > > Also renamed `GpuModels` fields from `major/minor` to > `arch_major/prod_major` to reflect their real meaning. > > This change was tested on Orange Pi 5 (rk3588s) board and the > results are as follows: > > Before this change: > > $ dmesg | grep 'tyr' > [ 19.698338] tyr fb000000.gpu: mali-unknown id 0xa867 major 0x67 minor 0x0 > status 0x5 > [ 19.699050] tyr fb000000.gpu: Features: L2:0x7120306 Tiler:0x809 Mem:0x301 > MMU:0x2830 AS:0xff > [ 19.699817] tyr fb000000.gpu: shader_present=0x0000000000050005 > l2_present=0x0000000000000001 tiler_present=0x0000000000000001 > [ 19.702493] tyr fb000000.gpu: Tyr initialized correctly. > > After this change: > > $ dmesg | grep 'tyr' > [ 19.591692] tyr fb000000.gpu: mali-g610 id 0xa867 major 0x0 minor 0x0 > status 0x5 > [ 19.592374] tyr fb000000.gpu: Features: L2:0x7120306 Tiler:0x809 Mem:0x301 > MMU:0x2830 AS:0xff > [ 19.593141] tyr fb000000.gpu: shader_present=0x0000000000050005 > l2_present=0x0000000000000001 tiler_present=0x0000000000000001 > [ 19.595831] tyr fb000000.gpu: Tyr initialized correctly. > > Signed-off-by: Onur Özkan <[email protected]>
Applied to drm-rust-next. Thanks!
