Re: [PATCH 08/12] drm/tyr: add MMU module

[Daniel Almeida]

> On 12 Feb 2026, at 08:05, Boris Brezillon <boris.brezil...@collabora.com> 
> wrote:
> 
> On Wed, 11 Feb 2026 17:37:09 -0800
> Deborah Brouwer <deborah.brou...@collabora.com> wrote:
> 
>> +
>> +impl Mmu {
>> +    pub(crate) fn new(
>> +        pdev: &platform::Device,
>> +        iomem: ArcBorrow<'_, Devres<IoMem>>,
>> +        gpu_info: &GpuInfo,
>> +    ) -> Result<Arc<Mmu>> {
> 
> Maybe the Mmu should be wrapped in a Devres, like we do with other HW
> components that require the underlying device to be bound to access
> registers. I mean, we do have iomem wrapper into a Devres, so maybe
> that's not needed, dunno.


Isn’t it enough to have the mmio range wrapped in Devres? That’s the
actual device resource that goes away when the device goes away.

> 
>> +        let slot_count = gpu_info.as_present.count_ones().try_into()?;
>> +        let as_manager = AddressSpaceManager::new(pdev, iomem, 
>> gpu_info.as_present)?;
>> +        let mmu_init = try_pin_init!(Self{
>> +            as_manager <- new_mutex!(SlotManager::new(as_manager, 
>> slot_count)?),
>> +        });
>> +        Arc::pin_init(mmu_init, GFP_KERNEL)
>> +    }
>