Thomas Zimmermann <[email protected]> writes: > Add corebootdrm, a DRM driver for coreboot framebuffers. The driver > supports a pre-initialized framebuffer with various packed RGB formats. > The driver code is fairly small and uses the same logic as the other > sysfb drivers. Most of the implementation comes from existing sysfb > helpers. > > Until now, coreboot relied on simpledrm or simplefb for boot-up graphics > output. Initialize the platform device for corebootdrm in the same place > in framebuffer_probe(). With a later commit, the simple-framebuffer should > be removed. > > v3: > - comment on _HAS_LFB semantics (Tzung-Bi) > - fix typo in commit description (Tzung-Bi) > - comment on simple-framebuffer being obsolete for coreboot > v2: > - reimplement as platform driver > - limit resources and mappings to known framebuffer memory; no > page alignment > - create corebootdrm device from coreboot framebuffer code > > Signed-off-by: Thomas Zimmermann <[email protected]> > Acked-by: Julius Werner <[email protected]> > ---
The driver looks good to me. I couldn't spot anything wrong on it. Reviewed-by: Javier Martinez Canillas <[email protected]> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
