On Thu, 11 Dec 2025 21:40:31 +0100 Nicolas Frattaroli <[email protected]> wrote:
> From: Daniel Stone <[email protected]> > > We should never be able to create a framebuffer with an unsupported > format, so throw a warning if this ever happens, instead of attempting > to stagger on. It doesn't look like you've changed the behaviour. Except that all the systems with PANIC_ON_WARN set will panic. I believe that is somewhere over 90% of systems. David > > Signed-off-by: Daniel Stone <[email protected]> > Signed-off-by: Nicolas Frattaroli <[email protected]> > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 498df0ce4680..20b49209ddcd 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane > *plane, > return 0; > > format = vop2_convert_format(fb->format->format); > - if (format < 0) > + /* We shouldn't be able to create a fb for an unsupported format */ > + if (WARN_ON(format < 0)) > return format; > > /* Co-ordinates have now been clipped */ >
