On Fri, Dec 05, 2025 at 03:59:09PM +0530, Akhil P Oommen wrote: > On 12/4/2025 7:49 PM, Dmitry Baryshkov wrote: > > On Thu, Dec 04, 2025 at 03:43:33PM +0530, Akhil P Oommen wrote: > >> On 11/26/2025 6:12 AM, Dmitry Baryshkov wrote: > >>> On Sat, Nov 22, 2025 at 03:03:10PM +0100, Konrad Dybcio wrote: > >>>> On 11/21/25 10:52 PM, Akhil P Oommen wrote: > >>>>> From: Jie Zhang <[email protected]> > >>>>> > >>>>> Add gpu and rgmu nodes for qcs615 chipset. > >>>>> > >>>>> Signed-off-by: Jie Zhang <[email protected]> > >>>>> Signed-off-by: Akhil P Oommen <[email protected]> > >>>>> --- > >>>> > >>>> [...] > >>>> > >>>>> + gpu_opp_table: opp-table { > >>>>> + compatible = "operating-points-v2"; > >>>>> + > >>>>> + opp-845000000 { > >>>>> + opp-hz = /bits/ 64 <845000000>; > >>>>> + required-opps = > >>>>> <&rpmhpd_opp_turbo>; > >>>>> + opp-peak-kBps = <7050000>; > >>>>> + }; > >>>> > >>>> I see another speed of 895 @ turbo_l1, perhaps that's for speedbins > >>>> or mobile parts specifically? > >>> > >>> msm-4.14 defines 7 speedbins for SM6150. Akhil, I don't see any of them > >>> here. > >> > >> The IoT/Auto variants have a different frequency plan compared to the > >> mobile variant. I reviewed the downstream code and this aligns with that > >> except the 290Mhz corner. We can remove that one. > >> > >> Here we are describing the IoT variant of Talos. So we can ignore the > >> speedbins from the mobile variant until that is supported. > > > > No, we are describing just Talos, which hopefully covers both mobile and > > non-mobile platforms. > > We cannot assume that. > > Even if we assume that there is no variation in silicon, the firmware > (AOP, TZ, HYP etc) is different between mobile and IoT version. So it is > wise to use the configuration that is commercialized, especially when it > is power related.
How does it affect the speed bins? I'd really prefer if we: - describe OPP tables and speed bins here - remove speed bins cell for the Auto / IoT boards - make sure that the driver uses the IoT bin if there is no speed bin declared in the GPU. -- With best wishes Dmitry
