Hello Harry Wentland,
Commit 41651f9d42eb ("drm/colorop: Add 1D Curve subtype") from Nov
14, 2025 (linux-next), leads to the following Smatch static checker
warning:
drivers/gpu/drm/drm_colorop.c:489 __drm_colorop_state_reset()
error: uninitialized symbol 'val'.
drivers/gpu/drm/drm_colorop.c
477 static void __drm_colorop_state_reset(struct drm_colorop_state
*colorop_state,
478 struct drm_colorop *colorop)
479 {
480 u64 val;
481
482 colorop_state->colorop = colorop;
483 colorop_state->bypass = true;
484
485 if (colorop->curve_1d_type_property) {
486 drm_object_property_get_default_value(&colorop->base,
487
colorop->curve_1d_type_property,
488 &val);
Smatch wants error checking on the drm_object_property_get_default_value()
function. We could just ignore this warning or I could add
drm_object_property_get_default_value() to the list of functions
which never actually fail.
--> 489 colorop_state->curve_1d_type = val;
490 }
491 }
regards,
dan carpenter
