On 11/25/25 2:33 AM, Ayushi Makhija wrote:
> Add anx7625 DSI to DP bridge device node.
>
> Signed-off-by: Ayushi Makhija <[email protected]>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
> ---
Couple of nits
[...]
> + vreg_12p0: regulator-vreg-12p0 {
> + compatible = "regulator-fixed";
> + regulator-name = "VREG_12P0";
> +
> + regulator-always-on;
> + regulator-boot-on;
These properties usually go at the end of the node (e.g. x1-crd.dtsi)
[...]
> +&i2c8 {
> + clock-frequency = <400000>;
> + status = "okay";
A \n before 'status' is customary
[...]
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + dsi2dp_bridge_in: endpoint {
Also before the last property and each following subnode
[...]
> &remoteproc_adsp {
> firmware-name = "qcom/qcs8300/adsp.mbn";
> status = "okay";
> @@ -419,6 +574,21 @@ dp_hot_plug_det: dp-hot-plug-det-state {
> function = "edp0_hot";
> bias-disable;
> };
> +
> + io_expander_intr_active: io-expander-intr-active-state {
> + pins = "gpio93";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + io_expander_reset_active: io-expander-reset-active-state {
> + pins = "gpio66";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-high;
This conflicts with the ACTIVE_LOW definition, plus it's generally
handled by the code via GPIO APIs => please drop output-high
Please also keep the entries sorted by the GPIO pin index
Konrad
