Hi
Am 03.12.25 um 10:07 schrieb Tvrtko Ursulin:
Valve Steam Deck has a 800x1280 portrait screen installed in a landscape
orientation. The firmware offers a software rotated 1280x800 mode which
GRUB can be made to switch to when displaying a boot menu. If this mode
was selected frame buffer drivers will see this fake mode and fbcon
rendering will be corrupted.
Lets therefore add a selective quirk inside the current "swap with and
height" handling, which will detect this exact mode and fix it up back to
the native one.
This will allow the DRM based frame buffer drivers to detect the correct
mode and, apply the existing panel orientation quirk, and render the
console in landscape mode with no corruption.
Signed-off-by: Tvrtko Ursulin <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Melissa Wen <[email protected]>
Cc: [email protected]
---
drivers/firmware/efi/sysfb_efi.c | 56 +++++++++++++++++++++++++++++---
1 file changed, 51 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_efi.c
index eacf9a50eab2..566492e67798 100644
--- a/drivers/firmware/efi/sysfb_efi.c
+++ b/drivers/firmware/efi/sysfb_efi.c
@@ -231,16 +231,42 @@ static const struct dmi_system_id
efifb_dmi_system_table[] __initconst = {
{},
};
+struct efifb_mode_fixup {
+ unsigned int width;
+ unsigned int height;
+ unsigned int linelength;
+};
+
static int __init efifb_swap_width_height(const struct dmi_system_id *id)
It's something different now. Can this please become a separate list
with a separate callback?
Best regards
Thomas
{
- swap(screen_info.lfb_width, screen_info.lfb_height);
- screen_info.lfb_linelength = (unsigned int)screen_info.lfb_depth *
- screen_info.lfb_width /
- BITS_PER_BYTE;
+ const struct efifb_mode_fixup *data = id->driver_data;
- return 1;
+ if (!data ||
+ (data->width == screen_info.lfb_width &&
+ data->height == screen_info.lfb_height)) {
+ swap(screen_info.lfb_width, screen_info.lfb_height);
+
+ if (data && data->linelength) {
+ screen_info.lfb_linelength = data->linelength;
+ screen_info.lfb_size = data->linelength * data->width;
+ } else {
+ screen_info.lfb_linelength = (unsigned
int)screen_info.lfb_depth *
+ screen_info.lfb_width /
+ BITS_PER_BYTE;
+ }
+
+ return 1;
+ }
+
+ return 0;
}
+static const struct efifb_mode_fixup efifb_steamdeck_mode_fixup = {
+ .width = 1280,
+ .height = 800,
+ .linelength = 3328,
+};
+
/*
* Some devices have a portrait LCD but advertise a landscape resolution (and
* pitch). We simply swap width and height for these devices so that we can
@@ -296,6 +322,26 @@ static const struct dmi_system_id
efifb_dmi_swap_width_height[] __initconst = {
},
.callback = efifb_swap_width_height,
},
+ {
+ /* Valve Steam Deck (Jupiter) */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
+ },
+ .callback = efifb_swap_width_height,
+ .driver_data = (void *)&efifb_steamdeck_mode_fixup,
+ },
+ {
+ /* Valve Steam Deck (Galileo) */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
+ },
+ .callback = efifb_swap_width_height,
+ .driver_data = (void *)&efifb_steamdeck_mode_fixup,
+ },
{},
};
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
