On 12/2/2025 1:12 PM, Murthy, Arun R wrote:
On 01-12-2025 12:16, Uma Shankar wrote:
From: Chaitanya Kumar Borah <[email protected]>
Add macros to identify intel specific color blocks. It will help
in mapping drm_color_ops to intel color HW blocks
v2:- Prefix enums with INTEL_* (Jani, Suraj)
- Remove unnecessary comments (Jani)
- Commit message improvements (Suraj)
Reviewed-by: Suraj Kandpal <[email protected]>
Signed-off-by: Chaitanya Kumar Borah <[email protected]>
Signed-off-by: Uma Shankar <[email protected]>
---
drivers/gpu/drm/i915/display/intel_display_limits.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_limits.h b/
drivers/gpu/drm/i915/display/intel_display_limits.h
index f0fa27e365ab..55fd574ba313 100644
--- a/drivers/gpu/drm/i915/display/intel_display_limits.h
+++ b/drivers/gpu/drm/i915/display/intel_display_limits.h
@@ -138,4 +138,12 @@ enum hpd_pin {
HPD_NUM_PINS
};
+enum intel_color_block {
Can this be intel_plane_color_block/pipeline as we get a new block/
pipeline for crtc which can later be named as intel_crtc_color_block/
pipeline
I had given it a thought but we don't really need a different enum
because all the intel_colorop code is agnostic to which object it is
attached to. Otherwise we have to create plane and crtc specific colorop
functions without much need of it. So, I envision it as a single colorop
enum type serving both plane and crtc but with appropriate prefix.
enum intel_color_block {
/* Plane color blocks */
INTEL_PLANE_CB_PRE_CSC_LUT,
INTEL_PLANE_CB_CSC,
INTEL_PLANE_CB_POST_CSC_LUT,
INTEL_PLANE_CB_3DLUT,
/* CRTC color blocks */
INTEL_CRTC_CB_PRE_CSC_LUT,
...
INTEL_CB_MAX
};
==
Chaitanya
Thanks and Regards,
Arun R Murthy
-------------------
+ INTEL_PLANE_CB_PRE_CSC_LUT,
+ INTEL_PLANE_CB_CSC,
+ INTEL_PLANE_CB_POST_CSC_LUT,
+
+ INTEL_CB_MAX
+};
+
#endif /* __INTEL_DISPLAY_LIMITS_H__ */
