On Sat, Nov 29, 2025 at 10:19:29PM -0800, Randy Dunlap wrote: > > > On 11/29/25 12:24 PM, Andy Shevchenko wrote: > > On Sat, Nov 29, 2025 at 02:53:01PM -0500, Yury Norov (NVIDIA) wrote: > >> The macro is related to sysfs, but is defined in kernel.h. Move it to > >> the proper header, and unload the generic kernel.h. > > > > Tough guy :-) > > I hope it builds well in your case. > > > > FWIW, > > https://lore.kernel.org/lkml/[email protected]/ > > https://lore.kernel.org/lkml/[email protected]/ > > https://lore.kernel.org/lkml/[email protected]/ > > > > Assuming it builds in allmodconfig, allyesconfig on x86_32/64 and arm/64 > > Reviewed-by: Andy Shevchenko <[email protected]> > > I don't build allyesconfigs any more (final? linking takes too long). > It builds successfully for arm64 allmodconfig, arm allmodconfig, > i386 allmodconfig, and x86_64 allmodconfig. > > And the source files that use VERIFY_OCTAL_PERMISSIONS() all build > successfully > (which means that they possibly include <linux/sysfs.h> indirectly, i.e., > by luck). There aren't many of them, so I checked: > > arch/arc/kernel/perf_event.c: arc_pmu->attr[j].attr.attr.mode = > VERIFY_OCTAL_PERMISSIONS(0444); > INDIRECT > drivers/edac/thunderx_edac.c: .mode = VERIFY_OCTAL_PERMISSIONS(_mode), > \ > INDIRECT > drivers/media/platform/amphion/vpu_dbg.c: > VERIFY_OCTAL_PERMISSIONS(0644), > INDIRECT > drivers/soc/aspeed/aspeed-uart-routing.c: .mode = > VERIFY_OCTAL_PERMISSIONS(0644) }, \ > INDIRECT > fs/xfs/xfs_error.c: .mode = VERIFY_OCTAL_PERMISSIONS(S_IWUSR | > S_IRUGO) }, \ > INDIRECT > include/linux/moduleparam.h: VERIFY_OCTAL_PERMISSIONS(perm), level, > flags, { arg } } > INDIRECT > > so all of them got lucky. :) > > Acked-by: Randy Dunlap <[email protected]> > Tested-by: Randy Dunlap <[email protected]>
Thanks, Randy. This series was tested by 0-day and LKP. 0-day runs allyesconfig, as far as I know. It only sends email in case of errors. LKP is OK, find the report below. All but XFS include it via linux/module.h -> linux/moduleparam.h path. XFS has a linkage layer: xfs.h -> xfs_linux.h-> linux/module.h, so it's pretty much the same. I think, module.h inclusion path is OK for this macro and definitely better than kernel.h. Notice, none of them, except for vgpu_dbg, include kernel.h directly. Thanks, Yury tree/branch: https://github.com/norov/linux stack_magic branch HEAD: d8dffbf7bce40e2fbfe077f9c9f4a3471786666f tracing: move tracing declarations from kernel.h to a dedicated header elapsed time: 1669m configs tested: 103 configs skipped: 2 The following configs have been built successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfig gcc-15.1.0 alpha defconfig gcc-15.1.0 arc allnoconfig gcc-15.1.0 arc defconfig gcc-15.1.0 arc randconfig-001-20251128 gcc-8.5.0 arc randconfig-002-20251128 gcc-15.1.0 arm allnoconfig clang-22 arm am200epdkit_defconfig gcc-15.1.0 arm aspeed_g5_defconfig gcc-15.1.0 arm randconfig-001-20251128 gcc-14.3.0 arm randconfig-002-20251128 gcc-8.5.0 arm randconfig-003-20251128 clang-22 arm randconfig-004-20251128 clang-17 arm s3c6400_defconfig gcc-15.1.0 arm u8500_defconfig gcc-15.1.0 arm64 allnoconfig gcc-15.1.0 arm64 randconfig-001-20251129 clang-22 arm64 randconfig-002-20251129 clang-22 arm64 randconfig-003-20251129 gcc-8.5.0 arm64 randconfig-004-20251129 clang-22 csky allnoconfig gcc-15.1.0 csky randconfig-001-20251129 gcc-15.1.0 csky randconfig-002-20251129 gcc-15.1.0 hexagon allnoconfig clang-22 hexagon randconfig-001-20251129 clang-22 hexagon randconfig-002-20251129 clang-22 i386 allnoconfig gcc-14 i386 randconfig-001-20251129 gcc-14 i386 randconfig-002-20251129 gcc-12 i386 randconfig-003-20251129 clang-20 i386 randconfig-004-20251129 gcc-14 i386 randconfig-005-20251129 clang-20 i386 randconfig-006-20251129 clang-20 i386 randconfig-007-20251129 gcc-14 i386 randconfig-011-20251129 clang-20 i386 randconfig-012-20251129 gcc-13 i386 randconfig-013-20251129 clang-20 i386 randconfig-014-20251129 clang-20 i386 randconfig-015-20251129 gcc-14 loongarch allnoconfig clang-22 loongarch defconfig clang-19 loongarch randconfig-001-20251129 gcc-15.1.0 loongarch randconfig-002-20251129 gcc-14.3.0 m68k allnoconfig gcc-15.1.0 m68k defconfig gcc-15.1.0 microblaze allnoconfig gcc-15.1.0 microblaze defconfig gcc-15.1.0 mips allnoconfig gcc-15.1.0 nios2 allnoconfig gcc-11.5.0 nios2 defconfig gcc-11.5.0 nios2 randconfig-001-20251129 gcc-11.5.0 nios2 randconfig-002-20251129 gcc-11.5.0 openrisc allnoconfig gcc-15.1.0 openrisc defconfig gcc-15.1.0 parisc allnoconfig gcc-15.1.0 parisc defconfig gcc-15.1.0 parisc generic-64bit_defconfig gcc-15.1.0 parisc randconfig-001-20251128 gcc-14.3.0 parisc randconfig-002-20251128 gcc-15.1.0 parisc64 defconfig gcc-15.1.0 powerpc allnoconfig gcc-15.1.0 powerpc pcm030_defconfig clang-22 powerpc randconfig-001-20251128 gcc-11.5.0 powerpc randconfig-002-20251128 clang-22 powerpc64 randconfig-001-20251128 clang-22 powerpc64 randconfig-002-20251128 gcc-8.5.0 riscv allnoconfig gcc-15.1.0 riscv defconfig clang-22 s390 allnoconfig clang-22 s390 defconfig clang-22 sh allnoconfig gcc-15.1.0 sh defconfig gcc-15.1.0 sparc allnoconfig gcc-15.1.0 sparc defconfig gcc-15.1.0 sparc randconfig-001-20251129 gcc-8.5.0 sparc randconfig-002-20251129 gcc-8.5.0 sparc64 defconfig clang-20 sparc64 randconfig-001-20251129 gcc-8.5.0 sparc64 randconfig-002-20251129 gcc-14.3.0 um allnoconfig clang-22 um defconfig clang-22 um i386_defconfig gcc-14 um randconfig-001-20251129 clang-22 um randconfig-002-20251129 gcc-14 um x86_64_defconfig clang-22 x86_64 allnoconfig clang-20 x86_64 defconfig gcc-14 x86_64 randconfig-011-20251129 gcc-14 x86_64 randconfig-012-20251129 gcc-14 x86_64 randconfig-013-20251129 gcc-14 x86_64 randconfig-014-20251129 clang-20 x86_64 randconfig-015-20251129 gcc-12 x86_64 randconfig-016-20251129 clang-20 x86_64 randconfig-071-20251129 gcc-14 x86_64 randconfig-072-20251129 clang-20 x86_64 randconfig-073-20251129 gcc-14 x86_64 randconfig-074-20251129 gcc-12 x86_64 randconfig-075-20251129 gcc-14 x86_64 randconfig-076-20251129 gcc-14 xtensa allnoconfig gcc-15.1.0 xtensa randconfig-001-20251129 gcc-10.5.0 xtensa randconfig-002-20251129 gcc-14.3.0 xtensa xip_kc705_defconfig gcc-15.1.0 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
