On Fri, 28 Nov 2025 14:14:17 +0000 Alice Ryhl <[email protected]> wrote:
> These methods just read the values stored in the op pointers without > modifying them, so it is appropriate to use const ptrs here. > > This allows us to avoid const -> mut pointer casts in Rust. > > Signed-off-by: Alice Ryhl <[email protected]> Reviewed-by: Boris Brezillon <[email protected]> > --- > drivers/gpu/drm/drm_gpuvm.c | 6 +++--- > include/drm/drm_gpuvm.h | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c > index > 9cd06c7600dc32ceee0f0beb5e3daf31698a66b3..e06b58aabb8ea6ebd92c625583ae2852c9d2caf1 > 100644 > --- a/drivers/gpu/drm/drm_gpuvm.c > +++ b/drivers/gpu/drm/drm_gpuvm.c > @@ -2283,7 +2283,7 @@ EXPORT_SYMBOL_GPL(drm_gpuvm_interval_empty); > void > drm_gpuva_map(struct drm_gpuvm *gpuvm, > struct drm_gpuva *va, > - struct drm_gpuva_op_map *op) > + const struct drm_gpuva_op_map *op) > { > drm_gpuva_init_from_op(va, op); > drm_gpuva_insert(gpuvm, va); > @@ -2303,7 +2303,7 @@ EXPORT_SYMBOL_GPL(drm_gpuva_map); > void > drm_gpuva_remap(struct drm_gpuva *prev, > struct drm_gpuva *next, > - struct drm_gpuva_op_remap *op) > + const struct drm_gpuva_op_remap *op) > { > struct drm_gpuva *va = op->unmap->va; > struct drm_gpuvm *gpuvm = va->vm; > @@ -2330,7 +2330,7 @@ EXPORT_SYMBOL_GPL(drm_gpuva_remap); > * Removes the &drm_gpuva associated with the &drm_gpuva_op_unmap. > */ > void > -drm_gpuva_unmap(struct drm_gpuva_op_unmap *op) > +drm_gpuva_unmap(const struct drm_gpuva_op_unmap *op) > { > drm_gpuva_remove(op->va); > } > diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h > index > 0d3fc1f6cac9966a42f3bc82b0b491bfefaf5b96..655bd9104ffb24170fca14dfa034ee79f5400930 > 100644 > --- a/include/drm/drm_gpuvm.h > +++ b/include/drm/drm_gpuvm.h > @@ -1121,7 +1121,7 @@ void drm_gpuva_ops_free(struct drm_gpuvm *gpuvm, > struct drm_gpuva_ops *ops); > > static inline void drm_gpuva_init_from_op(struct drm_gpuva *va, > - struct drm_gpuva_op_map *op) > + const struct drm_gpuva_op_map *op) > { > va->va.addr = op->va.addr; > va->va.range = op->va.range; > @@ -1265,13 +1265,13 @@ int drm_gpuvm_sm_unmap_exec_lock(struct drm_gpuvm > *gpuvm, struct drm_exec *exec, > > void drm_gpuva_map(struct drm_gpuvm *gpuvm, > struct drm_gpuva *va, > - struct drm_gpuva_op_map *op); > + const struct drm_gpuva_op_map *op); > > void drm_gpuva_remap(struct drm_gpuva *prev, > struct drm_gpuva *next, > - struct drm_gpuva_op_remap *op); > + const struct drm_gpuva_op_remap *op); > > -void drm_gpuva_unmap(struct drm_gpuva_op_unmap *op); > +void drm_gpuva_unmap(const struct drm_gpuva_op_unmap *op); > > /** > * drm_gpuva_op_remap_to_unmap_range() - Helper to get the start and range of >
