On Thu, 2025-11-13 at 15:51 +0100, Christian König wrote: > Using the inline lock is now the recommended way for dma_fence > implementations. > > So use this approach for the framework internal fences as well. > > Also saves about 4 bytes for the external spinlock. > > Signed-off-by: Christian König <[email protected]> > Reviewed-by: Tvrtko Ursulin <[email protected]>
Reviewed-by: Philipp Stanner <[email protected]> > --- > drivers/dma-buf/dma-fence-array.c | 5 ++--- > include/linux/dma-fence-array.h | 1 - > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/dma-buf/dma-fence-array.c > b/drivers/dma-buf/dma-fence-array.c > index 6657d4b30af9..c2119a8049fe 100644 > --- a/drivers/dma-buf/dma-fence-array.c > +++ b/drivers/dma-buf/dma-fence-array.c > @@ -204,9 +204,8 @@ void dma_fence_array_init(struct dma_fence_array *array, > > array->num_fences = num_fences; > > - spin_lock_init(&array->lock); > - dma_fence_init(&array->base, &dma_fence_array_ops, &array->lock, > - context, seqno); > + dma_fence_init(&array->base, &dma_fence_array_ops, NULL, context, > + seqno); > init_irq_work(&array->work, irq_dma_fence_array_work); > > atomic_set(&array->num_pending, signal_on_any ? 1 : num_fences); > diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h > index 079b3dec0a16..370b3d2bba37 100644 > --- a/include/linux/dma-fence-array.h > +++ b/include/linux/dma-fence-array.h > @@ -38,7 +38,6 @@ struct dma_fence_array_cb { > struct dma_fence_array { > struct dma_fence base; > > - spinlock_t lock; > unsigned num_fences; > atomic_t num_pending; > struct dma_fence **fences;
