On 8/26/2025 12:41 AM, Dmitry Baryshkov wrote:
On Mon, Aug 25, 2025 at 10:15:47PM +0800, Yongxing Mou wrote:
The cached drm_edid in msm_dp_panel was redundant and led to unnecessary
state management complexity. This change removes the drm_edid member from
Please see Documentation/process/submitting-patches.rst on how to write
commit messages. Please use imperative language instead of describing
the changes.
THe patch LGTM.
How about this:
"The cached drm_edid seems unnecessary here. Use the drm_edid pointer
directly in the plug stage instead of caching it. Remove the cached
drm_edid and the corresponding oneliner to simplify the code."
the panel structure and refactors related functions to use locally read
EDID data instead.
- Replaces msm_dp_panel_read_sink_caps() with msm_dp_panel_read_link_caps()
- Updates msm_dp_panel_handle_sink_request() to accept drm_edid as input
- Removes msm_dp_panel_get_modes() and drm_edid caching logic
- Cleans up unused drm_edid_free() calls
This simplifies EDID handling and avoids stale data issues.
Signed-off-by: Yongxing Mou <[email protected]>
---
drivers/gpu/drm/msm/dp/dp_display.c | 28 +++++++++++++++-------
drivers/gpu/drm/msm/dp/dp_panel.c | 47 ++++---------------------------------
drivers/gpu/drm/msm/dp/dp_panel.h | 9 +++----
3 files changed, 26 insertions(+), 58 deletions(-)
