Hi Dmitry,
I'm replying here to follow up on this patch.
It has been a while since your RB, so I just want to check if there are any
problems here for my patch,
or anything I can do better before it can be picked up?
Thanks,
Baihan
On Fri, Sep 26, 2025 at 09:14:57AM +0800, Yongbang Shi wrote:
From: Baihan Li <[email protected]>
The issue is that drm_connector_helper_detect_from_ddc() returns wrong
status when plugging or unplugging the monitor. Use HPD pin status in
DP's detect_ctx() for real physcal monitor in/out, and implementation
a complete DP detection including read DPCD, check if it's a branch
device and its sink count for different situations.
Fixes: 3c7623fb5bb6 ("drm/hisilicon/hibmc: Enable this hot plug detect of irq
feature")
Signed-off-by: Baihan Li <[email protected]>
Signed-off-by: Yongbang Shi <[email protected]>
---
ChangeLog:
v7 -> v8:
- fix build errors reported by kernel test robot <[email protected]>
Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/
v6 -> v7:
- add the check about branch devices, suggested by Dmitry Baryshkov.
v5 -> v6:
- use HPD status in DP detect_ctx(), suggested by Dmitry Baryshkov.
v4 -> v5:
- fix the commit message and DP detect_ctx(), suggested by Dmitry Baryshkov.
---
drivers/gpu/drm/hisilicon/hibmc/dp/dp_comm.h | 4 ++
drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.c | 12 +++++
drivers/gpu/drm/hisilicon/hibmc/dp/dp_hw.h | 6 +++
drivers/gpu/drm/hisilicon/hibmc/dp/dp_reg.h | 3 ++
.../gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 48 ++++++++++++++++++-
5 files changed, 71 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <[email protected]>
