On 19/11/2025 08:36, Dmitry Baryshkov wrote:
On Tue, Nov 18, 2025 at 12:30:38PM +0100, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>

The supported panel is LH546WF1-ED01, add compatible and adjust the
struct name to reflect that.

The standalone compatible lg,sw43408 will continue to work, even thou
there are no users yet.

.. no users _left_ ?

The compatible users wasn't introduced in the first place (the driver is written for Pixel 3, but the device-tree didn't got in back then).

[...]

  static int sw43408_backlight_update_status(struct backlight_device *bl)
@@ -214,7 +214,9 @@ static const struct drm_panel_funcs sw43408_funcs = {
  };
static const struct of_device_id sw43408_of_match[] = {
+       /* legacy */

Nit: I'd read this comment in a way that both entries are legacy. Would
it be possible to adjust this somehow (e.g. put legacy on the same line
or extend it, explaining that only lg,sw43408 is legacy).

Sure, I'll inline it.

Thanks
David


        { .compatible = "lg,sw43408", },
+       { .compatible = "lg,sw43408-lh546wf1-ed01", },

        { /* sentinel */ }
  };
  MODULE_DEVICE_TABLE(of, sw43408_of_match);

--

Reply via email to