Hi Deller, Any comments on this patch?,
Thanks! --- Javier Garcia On Sat, 15 Nov 2025 at 13:57, Javier Garcia <[email protected]> wrote: > > - Replace in `trident_pc_probe()` printk by dev_* fn's > - Delete the prefix `tridentfb:` from msg strings, not needed now. > > Signed-off-by: Javier Garcia <[email protected]> > --- > drivers/video/fbdev/tridentfb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c > index 516cf2a18757..17b7253b8fbe 100644 > --- a/drivers/video/fbdev/tridentfb.c > +++ b/drivers/video/fbdev/tridentfb.c > @@ -1631,7 +1631,7 @@ static int trident_pci_probe(struct pci_dev *dev, > } > > if (noaccel) { > - printk(KERN_DEBUG "disabling acceleration\n"); > + dev_dbg(&dev->dev, "disabling acceleration\n"); > info->flags |= FBINFO_HWACCEL_DISABLED; > info->pixmap.scan_align = 1; > } > @@ -1693,7 +1693,7 @@ static int trident_pci_probe(struct pci_dev *dev, > info->var.activate |= FB_ACTIVATE_NOW; > info->device = &dev->dev; > if (register_framebuffer(info) < 0) { > - printk(KERN_ERR "tridentfb: could not register > framebuffer\n"); > + dev_err(&dev->dev, "could not register framebuffer\n"); > fb_dealloc_cmap(&info->cmap); > err = -EINVAL; > goto out_unmap2; > -- > 2.50.1 >
