On Mon, Nov 17, 2025 at 01:28:44PM +0100, Josua Mayer wrote:
> Add missing ref on panel-common.yaml for this dsi panel so that common
> properties can be shared.
> 
> Drop reset-gpios and backlight as they are already in panel-common.
> 
> Switch from additionalProperties to unevaluatedProperties so that common
> panel properties are available without repeating them in this binding.
> 
> Notably panel-common defines the "port" property for linking panels to a
> source - which was missing from this panel. Mark it as required.
> 
> Signed-off-by: Josua Mayer <[email protected]>

Forgot my tag I think.
Acked-by: Conor Dooley <[email protected]>
pw-bot: not-applicable

> ---
>  .../devicetree/bindings/display/panel/ronbo,rb070d30.yaml  | 14 
> +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml 
> b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> index 04f86e0cbac91..6940373015833 100644
> --- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> @@ -9,6 +9,9 @@ title: Ronbo RB070D30 DSI Display Panel
>  maintainers:
>    - Maxime Ripard <[email protected]>
>  
> +allOf:
> +  - $ref: panel-common.yaml#
> +
>  properties:
>    compatible:
>      const: ronbo,rb070d30
> @@ -20,10 +23,6 @@ properties:
>      description: GPIO used for the power pin
>      maxItems: 1
>  
> -  reset-gpios:
> -    description: GPIO used for the reset pin
> -    maxItems: 1
> -
>    shlr-gpios:
>      description: GPIO used for the shlr pin (horizontal flip)
>      maxItems: 1
> @@ -35,10 +34,6 @@ properties:
>    vcc-lcd-supply:
>      description: Power regulator
>  
> -  backlight:
> -    description: Backlight used by the panel
> -    $ref: /schemas/types.yaml#/definitions/phandle
> -
>  required:
>    - compatible
>    - power-gpios
> @@ -47,5 +42,6 @@ required:
>    - shlr-gpios
>    - updn-gpios
>    - vcc-lcd-supply
> +  - port
>  
> -additionalProperties: false
> +unevaluatedProperties: false
> 
> -- 
> 2.51.0
> 

Attachment: signature.asc
Description: PGP signature

Reply via email to